Skip to content

[chore] Desiginate event.name as obsoleted #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[chore] Desiginate event.name as obsoleted #2606

wants to merge 1 commit into from

Conversation

@thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Aug 9, 2025 •
edited
Loading

Changes

This marks event.name as obsoleted rather than uncategorised,

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@thompson-tomo thompson-tomo requested review from a team as code owners August 9, 2025 04:34
@thompson-tomo thompson-tomo changed the title This marks event.name as obsoleted [chore] This marks event.name as obsoleted Aug 9, 2025
@thompson-tomo thompson-tomo changed the title [chore] This marks event.name as obsoleted [chore] Desiginate event.name as obsoleted Aug 11, 2025
pellared
pellared requested changes Aug 11, 2025
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a preference to undeprecate event.name per #2597

@github-project-automation github-project-automation bot moved this from Untriaged to Blocked in Semantic Conventions Triage Aug 11, 2025
@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Aug 11, 2025

This PR was designed to not change the definition of any attribute but rather is a documentation chore to increase consistency. Yes it might only be short lived change if the attribute is undeprecated but that is likely to take longer.

@joaopgrassi
Copy link
Member

joaopgrassi commented Aug 13, 2025

I'd also rather wait to the resolution of #2597 before merging this. Let's not make extra work for ourselves if it will be brought back.

lmolkova
lmolkova requested changes Aug 13, 2025
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason behind this change? It does not seem to bring any obvious benefits.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Aug 14, 2025

@lmolkova as part of #2607 I did a search for uncategorised to see which ones were not set. I then went through setting them with explicit ones when it was clear what it should be based on definition in weaver. In the case here there was no replacement attribute hence fitted nicely in obsoleted.

@lmolkova
Copy link
Member

lmolkova commented Aug 14, 2025

There is a replacement - it's the event_name property on the proto. It's not an attribute though.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Aug 20, 2025

Three is not a replacement attribute as we are talking about attributes. It is obsoleted as now it is not needing to be added as an attribute as the message property can be directly used.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 4, 2025
@pellared
Copy link
Member

pellared commented Sep 4, 2025

Closing per #2715

@pellared pellared closed this Sep 4, 2025
@thompson-tomo thompson-tomo deleted the chore/obsolete_EventName branch September 22, 2025 13:46
@pellared pellared mentioned this pull request Oct 14, 2025
Merged
@pellared
Copy link
Member

pellared commented Oct 27, 2025

@thompson-tomo, this can be reopened per #2914 and #2913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmolkova lmolkova lmolkova requested changes

@pellared pellared pellared requested changes

Assignees

No one assigned

Labels

Stale

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thompson-tomo @joaopgrassi @lmolkova @pellared